[6.0] Introduce Joomla 6.0 compatibility plugin#45336
[6.0] Introduce Joomla 6.0 compatibility plugin#45336HLeithner merged 21 commits intojoomla:6.0-devfrom
Conversation
joomla-cms-bot
added
the
NPM Resource Changed
|
@HLeithner You also have to change the extensions helper from "compat" to "compat6" here: https://github.com/joomla/joomla-cms/blob/6.0-dev/libraries/src/Extension/ExtensionHelper.php#L176 |
@HLeithner PR for 5.4 is #45371 . Question: I did my PR in the same way as PR PR #41738 did it on 4.4 for the 5 plugin. That means the plugin does not have any configuration parameters set in the database. That would not be a problem when the default values which the 6 plugin uses when reading its configuration are always so that all functionality is enabled. Is this the case? If not: Shall I add the right configuration parameters in the database to my PR? But this would mean we have to maintain them there and in 6.0-dev here when we add some new ones. |
|
by default, all parameters will be active in the code, so no parameters in the sql config is needed. thanks for the PR |
|
@HLeithner Is the file name of file "plugins/behaviour/compat6/src/Extension/Compat.php" right? Or shouldn't it be "Compat6.php" Update: I've just tested with my PR, and yes, the file name has to fit to the class name, so it has to be "Compat6.php". |
@HLeithner I've allowed myself to rename the file in your PR. |
|
thanks |
|
UPDATE: Please DISable the new compat6 plugin during installation in system-tests (#45414). |
@heelc29 We will handle that after the upmerge when we update this PR to the upmerged changes in the base branch and solve the conflicts. |
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
| * Load class names which are deprecated since joomla 4.0 and which will | ||
| * likely be removed in Joomla 7.0 | ||
| */ | ||
| if ($this->params->get('classes_aliases', '1')) { |
There was a problem hiding this comment.
| if ($this->params->get('classes_aliases', '1')) { | |
| if ($this->params->get('classes_aliases')) { |
| label="PLG_COMPAT6_FIELD_CLASSES_ALIASES_LABEL" | ||
| description="PLG_COMPAT6_FIELD_CLASSES_ALIASES_DESCRIPTION" | ||
| layout="joomla.form.field.radio.switcher" | ||
| default="1" |
There was a problem hiding this comment.
| default="1" | |
| default="0" |
There was a problem hiding this comment.
I keep them active for now and wait till we have a maintainer decision and what gets added to the list.
There was a problem hiding this comment.
There is a decission, check the last meeting report.
|
@HLeithner Now as @laoneo 's PR #44925 has been merged, this PR here has conflicts which can't be solved on GitHub. I think you know how to solve them. If not, let me know. |
This reverts commit cb6cb1d.
8 participants
In the today's maintainer meeting we came to the conclusion that making a new plugin with a new name makes it easier
for us to update and maintain in the future.
Considerations:
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Everything works without the old b/c plugin
After updating from 5.4, the old b/c plugin is still there.
Expected result AFTER applying this Pull Request
Everything works with the new b/c plugin
After updating from 5.4, the old b/c plugin is removed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed